Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading to ts 4.2 causes issues with function overloads #18

Closed
johnjesse opened this issue Mar 9, 2021 · 1 comment
Closed

Upgrading to ts 4.2 causes issues with function overloads #18

johnjesse opened this issue Mar 9, 2021 · 1 comment

Comments

@johnjesse
Copy link

I've made a minimal repro here

with ts: 4.1 - https://github.com/johnjesse/ts-dep-issue/tree/ts-4.1
and ts: 4.2 - https://github.com/johnjesse/ts-dep-issue/tree/ts-4.2

it's actually wrong in both cases - it doesn't cope with overloads well and incorrectly doesn't mark any of the overloads as deprecated with ts 4.1 - and all of them as deprecated with ts 4.2

I've opened this issue to track it - and for visibility - I'll take a look at fixing the rule and test it against my case

@johnjesse
Copy link
Author

johnjesse commented Mar 9, 2021

Actually - I don't think this is a bug here - I don't think we can know which jsdoc comment to use if an overload doesn't have one - it looks like this was a ts change to how these are resolved - that has been fixed here microsoft/TypeScript#43165

Once I'm sure that's the issue I'll close this Yep - this is the reason

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant