Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Remove cloneable-readable #155

Merged
merged 3 commits into from
Sep 26, 2022
Merged

feat!: Remove cloneable-readable #155

merged 3 commits into from
Sep 26, 2022

Conversation

phated
Copy link
Member

@phated phated commented Sep 11, 2022

This switches the project from cloneable-readable which uses readable-stream to teex which uses streamx. There seems to be some bugs with teex, so this is a draft for now.

cc @mafintosh

@phated
feat!: Remove cloneable-readable
6a76fb1 
feat!: Clone streams with teex
@phated phated added this to In progress in v5 via automation Sep 11, 2022
@phated phated mentioned this pull request Sep 11, 2022
Closed
@phated phated marked this pull request as ready for review September 23, 2022 21:26
@phated phated requested review from sttk and a team September 23, 2022 21:26
@phated
Copy link
Member Author

phated commented Sep 23, 2022

@sttk @yocontra this should be ready for review

@phated phated linked an issue Sep 23, 2022 that may be closed by this pull request
Switch to streamx #153
Closed
sttk
sttk approved these changes Sep 25, 2022
View reviewed changes
Copy link
Contributor

@sttk sttk left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phated I've reviewed this PR and there is nothing to be pointed out. Great!

@phated phated merged commit d4868f4 into master Sep 26, 2022
@phated phated deleted the phated/streamx branch September 26, 2022 21:00
@github-actions github-actions bot mentioned this pull request Sep 26, 2022
Merged
@phated phated moved this from In progress to Done in v5 Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sttk sttk sttk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
v5
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch to streamx
2 participants
@phated @sttk