Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: Normalize repository, dropping node <10.13 support #151

Merged
merged 7 commits into from
Sep 11, 2022
Merged

chore!: Normalize repository, dropping node <10.13 support #151

merged 7 commits into from
Sep 11, 2022

Conversation

sttk
Copy link
Contributor

@sttk sttk commented Jan 30, 2022

This PR updates this project:

  • Update dependency versions
  • Remove clone-buffer from dependencies
  • Update GitHub Actions files
  • Adds, changes and deletes some project files

@sttk sttk requested a review from phated January 30, 2022 13:02
@phated phated added this to In progress in v5 Jun 27, 2022
phated
phated reviewed Aug 25, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
phated
phated reviewed Aug 25, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
phated
phated reviewed Aug 25, 2022
View reviewed changes
test/file.js Outdated Show resolved Hide resolved
phated
phated reviewed Aug 25, 2022
View reviewed changes
test/file.js Show resolved Hide resolved
@sttk
Copy link
Contributor Author

sttk commented Sep 10, 2022

@phated I've modified what you pointed out. Please review again.

phated
phated reviewed Sep 11, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
phated
phated approved these changes Sep 11, 2022
View reviewed changes
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @sttk! I have applied some changes that I desired, but I'm going to merge this now so I can work on #153

@phated phated merged commit 9302802 into gulpjs:master Sep 11, 2022
@phated phated moved this from In progress to Done in v5 Sep 11, 2022
@github-actions github-actions bot mentioned this pull request Sep 11, 2022
Merged
@sttk
Copy link
Contributor Author

sttk commented Sep 11, 2022

@phated I'm sorry that I forgot to modify devDependencies in package.json. And I accept your changes. Thanks!

@sttk sttk deleted the chore-normalize-repository branch September 11, 2022 23:24
@github-actions github-actions bot mentioned this pull request Sep 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phated phated phated approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
v5
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sttk @phated