Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement preExistingComment stuff? #27

Open
phated opened this issue Apr 21, 2017 · 4 comments
Open

Implement preExistingComment stuff? #27

phated opened this issue Apr 21, 2017 · 4 comments
Labels
enhancement help wanted question

Comments

@phated
Copy link
Member

phated commented Apr 21, 2017

I'm not sure if we actually need to implement this, but it needs to be looked into. @nmccready might be able to explain more.
@nmccready
Copy link

So I am not sure if we need to worry about this anymore. But let me get you the original ticket that caused this logic mess.

@phated
Copy link
Member Author

phated commented Jun 12, 2017

@nmccready did you ever have a chance to dig deeper on this?

@nmccready
Copy link

Apologies I have not I look into this ASAP.

@phated
Copy link
Member Author

phated commented Jun 17, 2017

Thanks @nmccready - I'm probably going to ship a 1.0 without it (If I can finish this rebase and write docs today).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted question
Projects
post-v5
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nmccready @phated