Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Highlight timestamp as util.inspect hightlights Dates #23

Merged
merged 5 commits into from
Jan 7, 2022

Conversation

phated
Copy link
Member

@phated phated commented Dec 27, 2021

This also drops ansi-gray and timestamp in favor of using the platform.

Closes #18 (because they can configure the logging - see README)

@sttk please review! Will this help you support color theme on the timestamp when logging in gulp-cli?

This also drops ansi-gray and timestamp in favor of using the platform.
@phated phated requested a review from sttk December 27, 2021 22:26
@phated phated mentioned this pull request Dec 27, 2021
@phated
Copy link
Member Author

phated commented Jan 4, 2022

@sttk please review this when you have some time.

README.md Outdated Show resolved Hide resolved
Co-authored-by: contra <yo@contra.io>
sttk
sttk previously requested changes Jan 7, 2022
Copy link
Contributor

@sttk sttk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phated Sorry for the lay reply. I reviewed this PR and I found a slight mistake.

There is no other problem. Great!

README.md Outdated Show resolved Hide resolved
Co-authored-by: Takayuki Sato <sttk.xslet@gmail.com>
@phated phated dismissed sttk’s stale review January 7, 2022 18:58

Merged suggested changes

@phated phated merged commit 27c71a9 into master Jan 7, 2022
@phated phated deleted the phated/format-colors branch January 7, 2022 18:58
@github-actions github-actions bot mentioned this pull request Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grey colour not visible
3 participants