Attribute required or validate-if-empty without value or value="false" not handled correctly

[Species8372]

Hello,

we are using Parsley for a JSF-UI, so we do not have the possibility to conditionally add or remove pass-through-attributes in the UI-Tags. It is only possible to set the parsley-attributes to true or false (or nothing). However parsley treats an available "data-parsley-required" or "data-parsley-validate-if-empty" always as true, not considering its value (if there is a value).

<p:selectOneMenu  required="#{reqJSF}" requiredMessage="#{cc.attrs.requiredMessage}" 
                  pt:data-parsley-required="#{reqParsley}"  
				  pt:data-parsley-validate-if-empty="#{validateParsley}"  >  
                            //...
</p:selectOneMenu>

We fixed this by slightly changing the following two methods.

    _isRequired: function _isRequired() {
      if ('undefined' === typeof this.constraintsByName.required || !this.constraintsByName.required) return false;

      return false !== this.constraintsByName.required.requirements;
    },

	
	 needsValidation: function needsValidation(value) {
      if ('undefined' === typeof value) value = this.getValue();

      // If a field is empty and not required, it is valid
      // Except if `data-parsley-validate-if-empty` explicitely added, useful for some custom validators
      if (!value.length && !this._isRequired() && ('undefined' === typeof this.options.validateIfEmpty || !this.options.validateIfEmpty)) return false;

      return true;
    },

The change now considers a value for the two attributes if a value is given.
It would be nice considering this changes for a future release.

[marcandre]

Thanks for the bug report. I understand that it can be surprising that foo="false" is interpreted the same as foo="true".

The problem is that it's the spec for boolean HTML attributes, e.g. required. So changing this is a bit tricky...