Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when renaming folder #548

Closed
simon1tan opened this issue Nov 5, 2021 · 3 comments · Fixed by #552
Closed

Error when renaming folder #548

simon1tan opened this issue Nov 5, 2021 · 3 comments · Fixed by #552
Assignees
Milestone

Comments

@simon1tan
Copy link

Renamed a folder and received this error:

{:modified=>[], :added=>[], :removed=>["/mnt/data/services/auto/content/1"]}
E, [2021-10-31T18:33:04.468750 #12499] ERROR -- : Exception rescued in listen-run_thread:
NoMethodError: undefined method key?' for 1636153712.0:Float /var/lib/gems/2.7.0/gems/listen-3.7.0/lib/listen/record.rb:58:in block in dir_entries'
/var/lib/gems/2.7.0/gems/listen-3.7.0/lib/listen/record.rb:56:in transform_values' /var/lib/gems/2.7.0/gems/listen-3.7.0/lib/listen/record.rb:56:in dir_entries'
/var/lib/gems/2.7.0/gems/listen-3.7.0/lib/listen/directory.rb:12:in scan' /var/lib/gems/2.7.0/gems/listen-3.7.0/lib/listen/change.rb:60:in invalidate'
/var/lib/gems/2.7.0/gems/listen-3.7.0/lib/listen/adapter/base.rb:108:in _queue_change' /var/lib/gems/2.7.0/gems/listen-3.7.0/lib/listen/adapter/linux.rb:66:in _process_event'
/var/lib/gems/2.7.0/gems/listen-3.7.0/lib/listen/adapter/base.rb:44:in block (2 levels) in configure' /var/lib/gems/2.7.0/gems/rb-inotify-0.10.1/lib/rb-inotify/notifier.rb:217:in block in watch'
/var/lib/gems/2.7.0/gems/rb-inotify-0.10.1/lib/rb-inotify/watcher.rb:41:in callback!' /var/lib/gems/2.7.0/gems/rb-inotify-0.10.1/lib/rb-inotify/event.rb:128:in callback!'
/var/lib/gems/2.7.0/gems/rb-inotify-0.10.1/lib/rb-inotify/notifier.rb:264:in block in process' /var/lib/gems/2.7.0/gems/rb-inotify-0.10.1/lib/rb-inotify/notifier.rb:263:in each'
/var/lib/gems/2.7.0/gems/rb-inotify-0.10.1/lib/rb-inotify/notifier.rb:263:in process' /var/lib/gems/2.7.0/gems/rb-inotify-0.10.1/lib/rb-inotify/notifier.rb:236:in block in run'
/var/lib/gems/2.7.0/gems/rb-inotify-0.10.1/lib/rb-inotify/notifier.rb:232:in synchronize' /var/lib/gems/2.7.0/gems/rb-inotify-0.10.1/lib/rb-inotify/notifier.rb:232:in run'
/var/lib/gems/2.7.0/gems/listen-3.7.0/lib/listen/adapter/linux.rb:38:in _run' /var/lib/gems/2.7.0/gems/listen-3.7.0/lib/listen/adapter/base.rb:79:in block in start'
/var/lib/gems/2.7.0/gems/listen-3.7.0/lib/listen/thread.rb:26:in rescue_and_log' /var/lib/gems/2.7.0/gems/listen-3.7.0/lib/listen/thread.rb:18:in block in new'
--- Thread.new ---
/var/lib/gems/2.7.0/gems/listen-3.7.0/lib/listen/adapter/base.rb:75:in start' /usr/lib/ruby/2.7.0/forwardable.rb:235:in start'
/var/lib/gems/2.7.0/gems/listen-3.7.0/lib/listen/listener.rb:71:in block in <class:Listener>' /var/lib/gems/2.7.0/gems/listen-3.7.0/lib/listen/fsm.rb:124:in instance_eval'
/var/lib/gems/2.7.0/gems/listen-3.7.0/lib/listen/fsm.rb:124:in call' /var/lib/gems/2.7.0/gems/listen-3.7.0/lib/listen/fsm.rb:105:in transition_with_callbacks!'
/var/lib/gems/2.7.0/gems/listen-3.7.0/lib/listen/fsm.rb:72:in transition' /var/lib/gems/2.7.0/gems/listen-3.7.0/lib/listen/listener.rb:92:in start'

Code is basically the same as example except Listen.to(ARGV[0])

@ColinDKelley
Copy link
Collaborator

Thanks for reporting this bug.

It looks like this code expects a hash in values, but it's actually a floating point timestamp. I'm still looking to see where that came from.

        values.key?(:mtime) ? values : {}

@ColinDKelley
Copy link
Collaborator

@simon1tan I was able to create a failing test and put in a fix here: #552
Look good?

ColinDKelley added a commit to Invoca/listen that referenced this issue Dec 31, 2021
ColinDKelley added a commit to Invoca/listen that referenced this issue Jan 9, 2022
ColinDKelley added a commit to Invoca/listen that referenced this issue Jan 9, 2022
@ColinDKelley ColinDKelley linked a pull request Jan 13, 2022 that will close this issue
@ColinDKelley ColinDKelley self-assigned this Jan 13, 2022
@ColinDKelley ColinDKelley added this to the v3.7.1 milestone Jan 13, 2022
@ColinDKelley
Copy link
Collaborator

Fixed in v3.7.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants