Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly pass timeout as kwargs to wait_for_state #529

Merged
merged 1 commit into from Jan 14, 2021

Conversation

the-spectator
Copy link
Contributor

Issue

Related issue: socketry/falcon#138

Summary of Change

This PR correctly pass timeout as kwargs to method call wait_for_state.

@ColinDKelley
Copy link
Collaborator

Sorry about this bug. Looks like that timeout is getting interpreted as another state to wait for. (Hence no test frailures.)

I'm working on adding a couple tests now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants