Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #451: change windows install instructions to suggest platforms: instead of Gem.win_platform? #523

Merged

Conversation

ColinDKelley
Copy link
Collaborator

@ColinDKelley
Copy link
Collaborator Author

ColinDKelley commented Dec 1, 2020

@belluzj How does this look?

@ColinDKelley ColinDKelley linked an issue Dec 1, 2020 that may be closed by this pull request
@belluzj
Copy link

belluzj commented Dec 1, 2020

Thanks for looking into this! Sorry but I won't be able to reproduce my original issue now; however the patch looks fine from my recollection of the problem.

@ColinDKelley
Copy link
Collaborator Author

Thanks, I'll merge it now. We can always improve it later.

@ColinDKelley ColinDKelley merged commit a5a0496 into guard:master Dec 2, 2020
@ColinDKelley ColinDKelley deleted the issue-451/improve-readme-for-windows branch December 2, 2020 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wdm install advice on Windows could be improved
2 participants