Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logging should be unified #497

Closed
ColinDKelley opened this issue Sep 20, 2020 · 0 comments · Fixed by #498
Closed

logging should be unified #497

ColinDKelley opened this issue Sep 20, 2020 · 0 comments · Fixed by #498
Milestone

Comments

@ColinDKelley
Copy link
Collaborator

Currently the code logs 4 different ways:

  1. Listen.logger.info "message"
  2. Listen::Logger.info "message"
  3. _log :info, "message"
  4. self.class._log :info, "message"

These can all be unified with (1).

Also, there is a comment about clearing the logger, but the code doesn't actually support an empty (nil) logger. Instead, we can just have a comment describing how the caller can point the logger to /dev/null if they don't want logging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant