Use one fsevent_watch process per listener instead of one per dir
#471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Dec 5, 2019
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Error: RuboCop found unsupported Ruby version 2.2 in `TargetRubyVersion` para...
Error: RuboCop found unsupported Ruby version 2.2 in `TargetRubyVersion` parameter (in .rubocop.yml). 2.2-compatible analysis was dropped after version 0.69. Supported versions: 2.3, 2.4, 2.5, 2.6, 2.7
ioquatix
force-pushed
the
reduce_multiple_fsevent_processes
branch
from
97cf5ca
to
caf46a0
Compare
ioquatix
commented
Dec 5, 2019
| @@ -69,130 +69,4 @@ | |||
| it { should eq 1234 } | |||
| end | |||
| end | |||
|
|
|||
| describe 'multiple dirs' do | |||
There was a problem hiding this comment.
@tgxworld why did we have to remove all these specs?
|
@tgxworld thanks for your work. |
This was referenced Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.