Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore mutagen sync temporary files #469

Merged
merged 3 commits into from Oct 31, 2019
Merged

Ignore mutagen sync temporary files #469

merged 3 commits into from Oct 31, 2019

Conversation

nilbus
Copy link
Contributor

@nilbus nilbus commented Oct 25, 2019

Mutagen is a sync tool for remote development that copies files into place on a remote machine [running listen/guard] when edits are made on a local machine. To perform an atomic update, it creates a temp/staging file and moves it into place.

Normally this results in an addition, which results in the change being ignored by many guard plugins. Listen's QueueOptimizer can detect this as an "editor save" when it detects that a silenced temp file is moved to replace a watched file.

This patch updates the ignore pattern to detect mutagen temp files, silencing them and allowing the staging file move to be detected properly as a modification.

Post-merge tasks

@coveralls
Copy link

coveralls commented Oct 25, 2019

Coverage Status

Coverage decreased (-0.04%) to 97.843% when pulling bae2631 on nilbus:mutagen into 896c74c on guard:master.

@nilbus
Copy link
Contributor Author

nilbus commented Oct 26, 2019

Mutagen creates all its files with a .mutagen-temporary prefix (reference). I put the prefix pattern ending in .* in the suffixes where all other tempfile patterns are. Matching will be as performant as the others, but let me know if you think it should go into its own separate ignore prefixes list since it's not technically a suffix.

@benjaminoakes
Copy link

Thank you for addressing this

@rymai
Copy link
Member

rymai commented Oct 31, 2019

@nilbus Thank you, looks good to me! ❤️ 💛 💚 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants