Fix warnings in spec output #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's only possible to constrain the order in which calls are made when
using `expect`; not when using `allow`. Indeed you need at least two
calls to `expect` with the `ordered` qualifier to make this work.
The following warning was appearing in the spec output multiple times:
WARNING: `allow(...).to receive(..).ordered` is not supported and will have no effect, use `and_return(*ordered_values)` instead..
Thus the calls to `ordered` were not having any effect and so I have
removed them.
See the documentation [1] for more info.
[1]: https://relishapp.com/rspec/rspec-mocks/v/3-8/docs/setting-constraints/message-order
I was seeing multiple warnings like the following in the spec output:
W, [2019-08-07T11:42:43.494699 #48484] WARN -- : Adapter already configured!
This was because in the Adapter::Darwin spec in the "running threads"
describe block, both `subject.configure` and `subject.start` were being
called and the latter calls the former.
By moving the call to `subject.configure` into the "configuration"
describe block, we can avoid this problem.
|
@floehopper Thank you, looks good to me! ❤️ 💛 💚 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two types of warnings which were appearing in the spec output thus reducing the signal-to-noise ratio.