Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .travis.yml #427

Merged
merged 1 commit into from May 3, 2017
Merged

Update .travis.yml #427

merged 1 commit into from May 3, 2017

Conversation

junaruga
Copy link
Contributor

  • I updated Rubies to latest version.
  • I also added ruby-head as allow_failures.

I think adding ruby-head is useful.
Because we can prepare before next version Ruby 2.5 release.
Though it might not be useful until the actual preview release.
We can support the next version as faster.

We can see this kind of logic in rails, rspec and cucumber and etc.
https://github.com/rails/rails/blob/master/.travis.yml
https://github.com/rspec/rspec-core/blob/master/.travis.yml
https://github.com/cucumber/cucumber-ruby/blob/master/.travis.yml

Is it possible to merge?

Thanks.

@junaruga
Copy link
Contributor Author

Travis all tests were failed.
Because they changed Bundler's default behavior to run with --path recently maybe.
For the reason, ruby_dep installed at before_install is not loaded.

https://travis-ci.org/guard/listen/builds/224367627

$ bundle install --without development --path=${BUNDLE_PATH:-vendor/bundle}

@coveralls
Copy link

coveralls commented Apr 21, 2017

Coverage Status

Changes Unknown when pulling e1ce6aa on junaruga:feature/update-travis into ** on guard:master**.

@junaruga
Copy link
Contributor Author

I changed my code. and the situation was improved.

https://travis-ci.org/guard/listen/builds/224379269

Below tests are failed because of the ruby does not exists in the environment.
Ruby 2.3.4 at Mac, Ruby 2.4.1 at Mac, rbx2 at Linux at allows_failure

Requested binary installation but no rubies are available to download, consider skipping --binary flag.
Gemset '' does not exist, 'rvm rbx-2 do rvm gemset create ' first, or append '--create'.

jruby-head at Linux also failed for the test failure.

* Update Rubies to latest version.
* Add ruby-head as allow_failures.
  * It's good to know new version Ruby's issue as faster before the release.
  * fast_finish is to get the Travis result as faster
    without waiting the result of the "allow_failures" items.
    See https://blog.travis-ci.com/2013-11-27-fast-finishing-builds/
* Update it because Travis changed the behavior of "bundler install"
  to use --path.
  $ bundle install --path=${BUNDLE_PATH:-vendor/bundle}
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling f4d42b7 on junaruga:feature/update-travis into ** on guard:master**.

@coveralls
Copy link

coveralls commented Apr 21, 2017

Coverage Status

Changes Unknown when pulling f4d42b7 on junaruga:feature/update-travis into ** on guard:master**.

7 similar comments
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling f4d42b7 on junaruga:feature/update-travis into ** on guard:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling f4d42b7 on junaruga:feature/update-travis into ** on guard:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling f4d42b7 on junaruga:feature/update-travis into ** on guard:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling f4d42b7 on junaruga:feature/update-travis into ** on guard:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling f4d42b7 on junaruga:feature/update-travis into ** on guard:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling f4d42b7 on junaruga:feature/update-travis into ** on guard:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling f4d42b7 on junaruga:feature/update-travis into ** on guard:master**.

@junaruga
Copy link
Contributor Author

Finally all the test was passed.

@junaruga
Copy link
Contributor Author

After merging this PR, we must be able to merge #401 too

@junaruga
Copy link
Contributor Author

junaruga commented May 2, 2017

Hello, ping.

@rymai
Copy link
Member

rymai commented May 3, 2017

@junaruga Thanks, LGTM!

@rymai rymai merged commit 6577f20 into guard:master May 3, 2017
@junaruga
Copy link
Contributor Author

junaruga commented May 5, 2017

@rymai thanks for the merging!

@rymai
Copy link
Member

rymai commented May 5, 2017

@junaruga Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants