Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimization: check file size before checking hash #335

Closed
e2 opened this issue Aug 4, 2015 · 1 comment
Closed

optimization: check file size before checking hash #335

e2 opened this issue Aug 4, 2015 · 1 comment
Labels
✨ Feature Adds a new feature
Milestone
v3.3.0

Comments

@e2
Copy link
Contributor

e2 commented Aug 4, 2015

This may save hash checks on some filesystems in some cases.

Related implementation: #333

Also a different size is more reliable indicator of changes than atime/mtime.
@e2 e2 added the ✨ Feature Adds a new feature label Aug 4, 2015
@e2 e2 mentioned this issue Aug 4, 2015
Closed
marawan31 added a commit to marawan31/listen that referenced this issue Aug 5, 2015
@marawan31
use file size to check for modifications
0645593 
responds to issue guard#335
@marawan31 marawan31 mentioned this issue Aug 5, 2015
Merged
ioquatix pushed a commit that referenced this issue Aug 23, 2020
@marawan31 @ioquatix
use file size to check for modifications
debf5cb 
responds to issue #335
@ColinDKelley ColinDKelley added this to the v3.3.0 milestone Nov 6, 2020
@ColinDKelley
Copy link
Collaborator

Fix merged: #336

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
✨ Feature Adds a new feature
Projects
None yet
Milestone
v3.3.0
Development

No branches or pull requests
2 participants
@e2 @ColinDKelley