Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken with the pry 0.13.0 #953

Closed
lastobelus opened this issue Feb 26, 2020 · 5 comments · Fixed by #958
Closed

Broken with the pry 0.13.0 #953

lastobelus opened this issue Feb 26, 2020 · 5 comments · Fixed by #958

Comments

@lastobelus
Copy link

lastobelus commented Feb 26, 2020

/Users/lasto/.rvm/gems/ruby-2.7.0/gems/guard-2.16.1/lib/guard/jobs/pry_wrapper.rb:133:in `_setup': undefined method `file=' for #<Pry::History:0x00007fabc0258988>

this is because pry have refactored Pry.config.history to be a firstclass object.

EDIT:
Instead of setting Pry.config.history.file, should set Pry.config.history_file

@georgeu2000
Copy link

Yes, I ran into this too. Worked for me with Pry 0.11.3.

@yubele
Copy link

yubele commented Mar 22, 2020

I worked with pry 0.12.2.

This can be done with the following modifications.
https://github.com/newsdict/newsdict.io/pull/48/commits/011840d1016feb3abd87ed8fb38766d4b47804ca

@rymai
Copy link
Member

rymai commented Mar 23, 2020

There seem to be other issues (e.g. https://travis-ci.org/github/guard/guard/jobs/665304043?utm_source=github_status). I'll look into fixing those as well.

@IanVaughan
Copy link

I am seeing this now we upgraded pry-byebug which upgraded pry from 0.12.2 to 0.13.0

guard (2.16.1)
guard-compat (1.2.1)
guard-rspec (4.7.3)
guard-rubocop (1.3.0)

pry (0.13.0, 0.12.2)
pry-byebug (3.9.0, 3.8.0, 3.7.0)
pry-rails (0.3.9)

@rymai rymai changed the title Broken with the latest (unpublished but necessary for ruby 2.7) version of pry Broken with the pry 0.13.0 Mar 25, 2020
@rymai
Copy link
Member

rymai commented Mar 25, 2020

#958 hopefully fixes the Pry 0.13.0 compatibility issues. I've released Guard 2.16.2. Let me know how it goes. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants