Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] certifyVulnSpec: { vulnerability: { noVuln: true } not functioning on ENT? #1889

Closed
pxp928 opened this issue May 3, 2024 · 0 comments · Fixed by #1939
Closed

[bug] certifyVulnSpec: { vulnerability: { noVuln: true } not functioning on ENT? #1889

pxp928 opened this issue May 3, 2024 · 0 comments · Fixed by #1939
Assignees
Labels
bug Something isn't working

Comments

@pxp928
Copy link
Collaborator

pxp928 commented May 3, 2024

Describe the bug

# Setting noVuln to true return all packages that have no vulnerabilities
# Setting noVuln to false return all packages with vulnerabilities
query CertifyNoVuln {
  CertifyVuln(certifyVulnSpec: { vulnerability: { noVuln: false } }) {
    ...allCertifyVulnTree
  }
}

Not working via ENT on graphql playground

To Reproduce
Steps to reproduce the behavior:

  1. go run ./cmd/guacgql --gql-debug --gql-backend "ent"
  2. ingest some data (guac-data/docs)
  3. go run ./cmd/guacone certifier osv --poll=false
  4. query in graphql playground the above query and see that novuln is still returned

Expected behavior
Query should only return values that don't have type noVuln

GUAC version
main

@pxp928 pxp928 added bug Something isn't working trust issues describing providing additional information so that consumers can trust GUAC's results labels May 3, 2024
@pxp928 pxp928 changed the title [ingestion bug] certifyVulnSpec: { vulnerability: { noVuln: true } not functioning on ENT? [bug] certifyVulnSpec: { vulnerability: { noVuln: true } not functioning on ENT? May 3, 2024
@pxp928 pxp928 removed the trust issues describing providing additional information so that consumers can trust GUAC's results label May 3, 2024
@pxp928 pxp928 self-assigned this May 31, 2024
@kodiakhq kodiakhq bot closed this as completed in #1939 May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant