-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API change in k8s 1.23 breaking StatefulSetStatus? #30
Comments
The models are generated from the swagger specifications for kubernetes. It seems that
As you can see, this attribute is formally defined as required, so the code generator is ensuring that. I can however interpret from the description, that this field may not be provided without the feature gate |
Being discussed in kubernetes/kubernetes#109210 |
I'm curious, say this gets implemented and 1.24 has this required field that 1.21 did not. How is that reflected in the |
While lightkube itself is mostly version agnostic, each
Alternatively, you can check the models version ( |
Original k8s ticket is closed but this change still didn't got backported to 1.22 and 1.23 branches. |
…as `availableReplicas` optional
@ca-scribner I released lightkube-models 1.23.6.4 . Since the issue as been acknowledged and will be fixed I back-ported it to the last available spec for 1.23. After checking again, it seems 1.22 is not affected. |
I might have this wrong as I don't fully understand how
lightkube
andlightkube-models
interacts, but...I've recently found this code that worked with
lightkube-models==1.21.0.4
(and I believe,1.22.X
) now fails:I think it is because for class
StatefulSetStatus
theavailableReplicas
has changed from an optional kwarg (in 1.21.0.4) to a positional arg (in 1.23.X). Am I configuring something wrong betweenlightkube
andlightkube-models
, or is this an actual bug?The text was updated successfully, but these errors were encountered: