This repository has been archived by the owner on Jun 8, 2021. It is now read-only.
Remove pre-init assertion to check for non-debug GTK builds #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While previously checking for this could be used to determine if GTK was built with assertions enabled or not, this is not true anymore with later versions of GTK. There is no way to know if assertions were disabled or not at runtime. While disabling assertions easily causes memory unsafety in GTK code, it is nothing that can be disabled accidentally. Users deploying and running such code will have to live with the consequences. Fixes #821
|
👍 |
|
@GuillaumeGomez All green except for the well-known Windows failure :) |
|
Waiting for @EPashkin approval before. |
|
@sdroege Thanks 👍 |
|
Thanks! |
alex179ohm
pushed a commit
to alex179ohm/gtk
that referenced
this pull request
Oct 21, 2019
Use dox instead of creating new feature
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While previously checking for this could be used to determine if GTK was
built with assertions enabled or not, this is not true anymore with
later versions of GTK. There is no way to know if assertions were
disabled or not at runtime.
While disabling assertions easily causes memory unsafety in GTK code,
it is nothing that can be disabled accidentally. Users deploying and
running such code will have to live with the consequences.
Fixes #821