This repository has been archived by the owner on Jun 8, 2021. It is now read-only.
Acquire the default MainContext when initializing GTK #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is required for GTK to be able to own the default main context on the thread that initialized it, among other things to run its main loop on that. Make this more explicit by already acquiring it here during initialization. This also ensures that other API that checks that this very thread owns the main context works out of the box.
|
Good idea, thanks, 👍 |
|
Restarted CI. |
|
This will be green once #779 is merged. |
|
Restarted CI. |
|
@GuillaumeGomez green apart from appveyor being broken :) I'll fix that later... but it's worrying that gtk tests don't work there. The setup seems broken. |
|
appveyor worked, travis didn't. Is it expected? |
alex179ohm
pushed a commit
to alex179ohm/gtk
that referenced
this pull request
Oct 21, 2019
Use Option<&T> instead of &Option<T> for signal callback parameters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on gtk-rs/glib#447