Bring Travis and AppVeyor configurations in sync with the GLib one #779
Conversation
.travis.yml
Outdated
| - cargo doc --features "dox" | ||
| # catch any sneaked in lgpl docs | ||
| - cargo build --features purge-lgpl-docs --jobs 1 | ||
| - git diff -R --exit-code |
There was a problem hiding this comment.
You should've said that before all the other ones are merged. I asked if that's fine in the other PRs because the GLib one didn't have any of this and nobody replied to that and then it was merged.
At this point I'd prefer to have all this merged and then we can as a separate step look at what can be improved in the CI configuration. That way it does not go out of sync between all the different repos again.
There was a problem hiding this comment.
Sorry for missing this.
All crates with embed-lgpl-docs must have tests for it.
Good that cargo allow --features ",v3_16," without any question
cargo test --features "embed-lgpl-docs,$FEATURES" --jobs 1
Please just start write right with this PR.
There was a problem hiding this comment.
You redo the other ones then? I do gdk and the ones I didn't touch yet still. My patience with CI things is getting to an end :)
For doing things via Docker btw:
https://docs.travis-ci.com/user/docker/
https://hub.docker.com/_/fedora/?tab=tags
Seems a bit more complicated than with gitlab-ci but still manageable. Then we could at least test the latest versions.
There was a problem hiding this comment.
I do gdk and the ones I didn't touch yet still
I meant gdk-pixbuf, not gdk.
|
@EPashkin @GuillaumeGomez that appveyor failure looks transient, can you retry it or just merge? |
|
Weird error. Let's merge for now. Thanks! |
|
Seems we broke test on win32 again 😢 |
|
So it wasn't transient? :-/ Urg... |
|
We just not tested gtk on apveyor before, maybe because win32 test always fails 😉 |
|
That might explain it! Haha |
|
I think the problem is DLL hell. There seem to be cygwin and mingw DLLs mixed in the PATH here, some of them at least coming from git. How can this be cleaned up? |
|
@EPashkin any ideas? :) |
Fix gconstpointer fixup
No description provided.