Add CastNone trait #843
Merged
Add CastNone trait #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes gtk-rs#842
sdroege
reviewed
Dec 1, 2022
sdroege
reviewed
Dec 1, 2022
sdroege
reviewed
Dec 1, 2022
sdroege
reviewed
Dec 1, 2022
Co-authored-by: Bilal Elmoussaoui <belmouss@redhat.com>
|
I don't like the API but if people think this is useful to have let's merge it. @bilelmoussaoui @GuillaumeGomez? |
I think the use case for this API would be mostly GTK and libraries building on top of it as mentioned on the Matrix channel. I would suggest adding a warning to not go through this API unless downcasting/upcasting to the wrong type is a programmer error and the fallback shouldn't handled in that case. |
sdroege
approved these changes
Dec 3, 2022
bilelmoussaoui
approved these changes
Dec 4, 2022
bilelmoussaoui
added
the
needs-backport
bilelmoussaoui
pushed a commit
that referenced
this pull request
Dec 5, 2022
* Add CastNone trait Closes #842 * Add CastNone to prelude, add dynamic_cast * Add example for CastNone * Describe type using turbofish op
pbor
removed
the
needs-backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #842