Skip to content
This repository has been archived by the owner on Jun 8, 2021. It is now read-only.

Add init/clear function for boxed types #496

Merged
merged 2 commits into from
Jun 13, 2019
Merged

Add init/clear function for boxed types #496

merged 2 commits into from
Jun 13, 2019

Conversation

sdroege
Copy link
Member

@sdroege sdroege commented Jun 10, 2019 

These allow allocated them on our side and releasing all memory of them
again. It is needed for functions that take an out parameter and require
us to allocate the underlying object.

Fixes https://github.com/gtk-rs/glib/issues/469

@sdroege
Add init/clear function for boxed types
c54924e 
These allow allocated them on our side and releasing all memory of them
again. It is needed for functions that take an out parameter and require
us to allocate the underlying object.

Fixes #469
@sdroege
Use new init/clear functions for glib::Date
7c647aa
@sdroege sdroege mentioned this pull request Jun 10, 2019
Closed
@sdroege
Copy link
Member Author

sdroege commented Jun 10, 2019

The build failure requires changes in the gtk crate btw, to add these functions to those types there.

@GuillaumeGomez
Copy link
Member

Looks good to me! 👍

@sdroege
Copy link
Member Author

sdroege commented Jun 10, 2019

Looks good to me! +1

#469 (comment) seems fine to you too?

@GuillaumeGomez
Copy link
Member

I didn't see that comment. Seems quite complicated...

@sdroege
Copy link
Member Author

sdroege commented Jun 10, 2019

I didn't see that comment. Seems quite complicated...

Comment that there please :P And it's complicated indeed, but I don't see an easier solution. Shouldn't matter much though as this will only be needed by very few types, and people will notice if it's missing.

@sdroege sdroege mentioned this pull request Jun 10, 2019
Merged
@EPashkin
Copy link
Member

@sdroege Thanks again, 👍

@sdroege sdroege merged commit c5e2632 into gtk-rs:master Jun 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sdroege @GuillaumeGomez @EPashkin