This repository has been archived by the owner on Jun 8, 2021. It is now read-only.
Remove traits for disguised types without children #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Is it ready or not yet? (Same question for all same PRs) Otherwise the current code looks good to me. |
|
Oh and the diff is failing. |
|
It not ready because gir's part not merged. |
|
Makes sense! |
EPashkin
force-pushed
the
fix_disguised_final_types
branch
from
bcfa44a
to
51813d2
Compare
EPashkin
force-pushed
the
fix_disguised_final_types
branch
from
51813d2
to
4d1e48f
Compare
EPashkin
changed the title
|
Thanks! |
|
👍 |
|
@EPashkin Can you reopen this PR please? I removed this commit by mistake (sorry). :-/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of gtk-rs/gir#760
cc @GuillaumeGomez, @sdroege