Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add possibility to setup a custom logger for kubectl configuration #1384

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add possibility to setup a custom logger for kubectl configuration #1384

wants to merge 1 commit into from

Conversation

lahabana
Copy link
Contributor

@lahabana lahabana commented Jan 9, 2024 •
edited

Description

Fixes #1383.

This enables users to not log messages like: "Configuring Kubernetes client using config file"

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added option ConfigLogger in KubectlOptions to specify a custom logger for configuration

Migration Guide

@lahabana
add possibility to setup a custom logger for kubectl configuration
3354a0d 
This enables users to not log messages like: "Configuring Kubernetes
client using config file"

Fix gruntwork-io#1383

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@lahabana
Copy link
Contributor Author

@denis256 any chance to get that in?

denis256
denis256 reviewed Mar 18, 2024
View reviewed changes
modules/k8s/kubectl_options.go
@@ -15,6 +15,8 @@ type KubectlOptions struct {
InClusterAuth bool
RestConfig *rest.Config
Logger *logger.Logger
// ConfigLogger is useful to set a different logger when configuring kubectl with a config. This can significantly reduce verbosity of tests
ConfigLogger *logger.Logger
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, what will happen if the logger will not be provided?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis256 denis256 denis256 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

reduce logging when configuring kubectl
2 participants
@lahabana @denis256