Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include project name into docker-compose options #1187

Merged
merged 6 commits into from
Jan 14, 2023

Conversation

apenella
Copy link

@apenella apenella commented Oct 6, 2022

Description

That PR is an enhancement for the docker-compose test suite. A new attribute has been included, on docker-compose options, that allows customizing the project name on docker-compose.

When the options attribute does not provide the project name, strings.ToLower(t.Name()) is used as the default value.

TODOs

Read the Gruntwork contribution guidelines.

  • [n/a] Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide. (n/a)

Release Notes (draft)

New attribute included on docker-compose options. It is named ProjectName and allows to customize the project name when docker-compose is executed.

@apenella apenella marked this pull request as ready for review October 6, 2022 06:08
@apenella apenella changed the title [WIP] Include project name into docker-compose options Include project name into docker-compose options Oct 6, 2022
@denis256
Copy link
Member

Hi,
will be helpful to have a test that will track that projectName will be passed to docker compose, it will help to detect in the future if passing will stop working.

@apenella
Copy link
Author

Hi @denis256!
Sure, I will prepare some tests.
Since there is any test for docker-compose, do you have any tips or preferences?
I have seen that, on your test, you used to execute commands on the host which runs the test, but I am not sure if this is the expected approach.

In that case, I guess that I need to update the contributing guide, am I right?
https://terratest.gruntwork.io/docs/community/contributing/#developing-terratest

@apenella
Copy link
Author

Hi @denis256
I already add tests to the custom project name.

@apenella
Copy link
Author

apenella commented Jan 9, 2023

Hi! @zackproser @denis256
I don't know if is still pending anything from my side before you could review that PR.

Thank you!

@denis256 denis256 merged commit 6264798 into gruntwork-io:master Jan 14, 2023
@apenella apenella deleted the docker-compose-projectname branch January 14, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants