Allow for ExtraArgs in Helm Module for AddRepo #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nxf5025
requested review from
yorinasub17,
zackproser,
rhoboat and
denis256
as code owners
nxf5025
force-pushed
the
feature/private-helm-repo-add
branch
from
c66f76f
to
7a48981
Compare
nxf5025
force-pushed
the
feature/private-helm-repo-add
branch
from
7a48981
to
99c78dd
Compare
|
@yorinasub17 - Anything else you need from my end to get this looked at? |
denis256
approved these changes
Sep 4, 2022
|
Released as part of https://github.com/gruntwork-io/terratest/releases/tag/v0.40.21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1165.
This enables users to pass extra arguments to the addRepo function in the helm module. An example would include passing username/password credentials to authenticate against a private repository.
TODOs
Read the Gruntwork contribution guidelines.
Release Notes (draft)
Added the ability to pass in ExtraArgs to the helm addRepo function.