Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(opa): Export downloadPolicyE function #1159

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

joshmyers
Copy link
Contributor

Description

Export downloadPolicyE function

We're using conftest so the opa module is almost what we want, but not
quite. Instead we'd like to use this function in our tests to download
our conftest rego policies from a remote URL. In order to do that, this
needs to be an exported function.

TODOs

Read the Gruntwork contribution guidelines.

  • [N/A] Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Export DownloadPolicyE function.

We're using conftest so the opa module is almost what we want, but not
quite. Instead we'd like to use this function in our tests to download
our conftest rego policies from a remote URL. In order to do that, this
needs to be an exported function.
@joshmyers
Copy link
Contributor Author

@yorinasub17 any chance of getting some 👀 on this PR? 🙇

Copy link
Contributor

@yorinasub17 yorinasub17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution and apologize for the delay! I'll kick off a regression test and if it passes, we can merge this in.

@yorinasub17
Copy link
Contributor

@joshmyers
Copy link
Contributor Author

Thank you @yorinasub17 - I get a 404 from that link.

@yorinasub17
Copy link
Contributor

You'll be able to see it once you log into circleci using your github account.

Copy link
Contributor

@yorinasub17 yorinasub17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build failed, but I have confirmed that the test failures are unrelated to this change, so we can move forward with this change. Thanks again for the contribution!

@yorinasub17 yorinasub17 merged commit 64dd023 into gruntwork-io:master Aug 15, 2022
@joshmyers
Copy link
Contributor Author

joshmyers commented Aug 15, 2022

Great, thanks @yorinasub17. Yup the fail looked unrelated. Any ideas when a release could be cut?

nvm - done 🎉

@joshmyers joshmyers deleted the export_downloadpolicye branch August 15, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants