-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(opa): Export downloadPolicyE function #1159
feat(opa): Export downloadPolicyE function #1159
Conversation
We're using conftest so the opa module is almost what we want, but not quite. Instead we'd like to use this function in our tests to download our conftest rego policies from a remote URL. In order to do that, this needs to be an exported function.
@yorinasub17 any chance of getting some 👀 on this PR? 🙇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the contribution and apologize for the delay! I'll kick off a regression test and if it passes, we can merge this in.
Thank you @yorinasub17 - I get a 404 from that link. |
You'll be able to see it once you log into circleci using your github account. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build failed, but I have confirmed that the test failures are unrelated to this change, so we can move forward with this change. Thanks again for the contribution!
Great, thanks @yorinasub17. Yup the fail looked unrelated. nvm - done 🎉 |
Description
Export downloadPolicyE function
We're using conftest so the opa module is almost what we want, but not
quite. Instead we'd like to use this function in our tests to download
our conftest rego policies from a remote URL. In order to do that, this
needs to be an exported function.
TODOs
Read the Gruntwork contribution guidelines.
Release Notes (draft)
Export
DownloadPolicyE
function.