Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add utility function for validating slack integrations #1114

Merged
merged 1 commit into from May 5, 2022

Conversation

yorinasub17
Copy link
Contributor

This migrates one of our internal validation functions (from terraform-aws-monitoring) to terratest so that it can be reused across out modules.

The new function slack.ValidateExpectedSlackMessageE can be used to check if a particular message text has been posted by a bot in the given channel, which is useful for integration testing of slack based workflows.

@yorinasub17
Copy link
Contributor Author

NOTE: I investigated the test failures and they don't seem to be related to this. In particular, the new test TestValidateSlackMessage passed, which is the only one that matters for this change set since the code is isolated in a new package.

Copy link
Contributor

@infraredgirl infraredgirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yorinasub17
Copy link
Contributor Author

Thanks for review! Merging now.

@yorinasub17 yorinasub17 merged commit 62f6d38 into master May 5, 2022
@yorinasub17 yorinasub17 deleted the feature/validate-slack-messages branch May 5, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants