Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecated circleci images to latest #1084

Merged
merged 2 commits into from Mar 15, 2022

Conversation

yorinasub17
Copy link
Contributor

Update deprecated circleci images to latest

Copy link
Contributor

@marinalimeira marinalimeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -112,8 +112,8 @@ jobs:
- $HOME/go/src/

# The weird way you have to set PATH in Circle 2.0
- run: echo 'export PATH=$HOME/.local/bin:$HOME/go/bin:$HOME/terraform:$HOME/packer:$PATH'
>> $BASH_ENV
- run: |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What difference does it make to use the |?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

| ensures the string is treated as "raw" multiline, and prevents scripts/yaml libraries from reflowing the text to keep column width.

@yorinasub17
Copy link
Contributor Author

Thanks for review! Merging now.

@yorinasub17 yorinasub17 merged commit dae956e into master Mar 15, 2022
@yorinasub17 yorinasub17 deleted the chore/update-circleci-image branch March 15, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants