Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Statefulset deployments #136

Open
rvc-mf opened this issue May 18, 2022 · 0 comments
Open

Add support for Statefulset deployments #136

rvc-mf opened this issue May 18, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@rvc-mf
Copy link

rvc-mf commented May 18, 2022

I would like to add support for Statefulset deployments to this helm chart. I believe this can be done with relatively few (and non-breaking?) changes:

  • Add an optional field called workloadType to values.yaml, where the default value is deployment but statefulset is also an option.
  • Add a _statefulset_spec.tpl template which gets used when workloadType is set to statefulset. In turn, _deployment_spec_tpl only gets used when workloadType is set to deployment.
  • Add an optional updateStrategy field to values.yaml which gets injected into updateStrategy on statefulset workloads (workloadType: statefulset). deploymentStrategy continues getting injected into strategy on deployment workloads.
  • Add an optional name field under service due to Statefulset workload requirements. service could still have enabled: false if the service resource is created outside of the chart.

I consider these changes possibly non-breaking because as long as the default value of workloadType is deployment, the chart should behave exactly as it does currently. Also, I don't expect any downtime implications from these changes.

An alternative would be creating different helm charts for statefulset deployments, but I think time will be better spent upgrading this Chart instead.

That being said, is there anything that I'm not seeing that could become a problem with this approach? I'm planning on coding this up soon, but I'd appreciate any feedback 👍🏼.

@rvc-mf rvc-mf added the enhancement New feature or request label May 18, 2022
@rvc-mf rvc-mf mentioned this issue May 19, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant