Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use path.basename for sourceMappingURL. #322

Merged
merged 1 commit into from Aug 9, 2016
Merged

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Jul 21, 2016

Now the sourceMappingURL will be the same as the CSS file, if not specified.

Fixes #299, fixes #236, fixes #221.

/CC @vladikoff

Now the sourceMappingURL will be the same as the CSS file, if not specified.
@kurtextrem
Copy link

@XhmikosR also ping :)

@XhmikosR
Copy link
Member Author

XhmikosR commented Aug 2, 2016

I don't see the ping reason. Still waiting for a review.

@kurtextrem
Copy link

This fix is important (the workaround is only written in one of the linked bugs), it's not even one full line...
I mean, there is no way this becomes worse. So why not merge?

@XhmikosR
Copy link
Member Author

XhmikosR commented Aug 2, 2016

No idea if the fix is listed. I hit this bug in gruntjs website repo and
decided to take a look.

Even if it's one line there are no tests. Plus it's not like I can publish
a new version on npm myself.

On Aug 2, 2016 13:16, "Jacob Groß" notifications@github.com wrote:

This fix is important (the workaround is only written in one of the linked
bugs), it's not even one full line...
I mean, there is no way this becomes worse. So why not merge?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#322 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAVVtbGjFTdqQckfRspXcWN72szzC5Xwks5qbxj9gaJpZM4JRwAE
.

@XhmikosR XhmikosR merged commit 924189e into master Aug 9, 2016
@XhmikosR XhmikosR deleted the sourceMappingURL branch August 9, 2016 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants