Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump puppeteer to 8.0.0 #332

Merged
merged 2 commits into from May 12, 2021
Merged

bump puppeteer to 8.0.0 #332

merged 2 commits into from May 12, 2021

Conversation

fred104
Copy link
Contributor

@fred104 fred104 commented May 10, 2021

Recently we encountered an error from Chromium after upgrading Mac to 11.3.1. This issue can be resolved after upgrading to newer puppeteer which will use new version of Chromium.

Error caught from Headless Chrome. More info can be found by opening the Spec Runner in a browser.
>> Error: Page crashed!
>>   at Page._onTargetCrashed (/Users/fred/project/node_modules/puppeteer/lib/Page.js:215:24)
>>   at CDPSession.<anonymous> (/Users/fred/project/node_modules/puppeteer/lib/Page.js:123:56)
>>   at CDPSession.emit (events.js:315:20)
>>   at CDPSession._onMessage (/Users/fred/project/node_modules/puppeteer/lib/Connection.js:200:12)
>>   at Connection._onMessage (/Users/fred/project/node_modules/puppeteer/lib/Connection.js:112:17)
>>   at WebSocket.<anonymous> (/Users/fred/project/node_modules/puppeteer/lib/WebSocketTransport.js:44:24)
>>   at WebSocket.onMessage (/Users/fred/project/node_modules/ws/lib/event-target.js:120:16)
>>   at WebSocket.emit (events.js:315:20)
>>   at Receiver.receiverOnMessage (/Users/fred/project/node_modules/ws/lib/websocket.js:789:20)
>>   at Receiver.emit (events.js:315:20)
>>   at Receiver.dataMessage (/Users/fred/project/node_modules/ws/lib/receiver.js:422:14)
>>   at Receiver.getData (/Users/fred/project/node_modules/ws/lib/receiver.js:352:17)
>>   at Receiver.startLoop (/Users/fred/project/node_modules/ws/lib/receiver.js:138:22)
>>   at Receiver._write (/Users/fred/project/node_modules/ws/lib/receiver.js:74:10)
>>   at doWrite (_stream_writable.js:403:12)
>>   at writeOrBuffer (_stream_writable.js:387:5)
>>   at Receiver.Writable.write (_stream_writable.js:318:11)
>>   at Socket.socketOnData (/Users/fred/project/node_modules/ws/lib/websocket.js:864:35)
>>   at Socket.emit (events.js:315:20)
>>   at addChunk (_stream_readable.js:295:12)
>>   at readableAddChunk (_stream_readable.js:271:9)
>>   at Socket.Readable.push (_stream_readable.js:212:10)
>>   at TCP.onStreamRead (internal/stream_base_commons.js:186:23)

@fred104
Copy link
Contributor Author

fred104 commented May 10, 2021

It seems to me that we probably need to drop node 8 support.

@fred104
Copy link
Contributor Author

fred104 commented May 11, 2021

@vladikoff What do you think?

@fred104
Copy link
Contributor Author

fred104 commented May 12, 2021

@steveoh @vladikoff Would you mind reviewing this PR?

@vladikoff vladikoff merged commit 3b3abc7 into gruntjs:main May 12, 2021
@vladikoff
Copy link
Member

@fred104 hey yeah, thanks for the PR! 👍 we need to move to github actions soon for this

@fred104
Copy link
Contributor Author

fred104 commented May 12, 2021

@vladikoff Do you happen to know when to publish this to npm repository?

@vladikoff
Copy link
Member

vladikoff commented May 12, 2021 via email

@fred104
Copy link
Contributor Author

fred104 commented May 12, 2021

Got it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants