Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xDS interop GCE framework: pin grpcio-tools to use protobuf 3.x #31191

Merged
merged 2 commits into from Sep 30, 2022
Merged

xDS interop GCE framework: pin grpcio-tools to use protobuf 3.x #31191

merged 2 commits into from Sep 30, 2022

Conversation

sergiitk
Copy link
Member

@sergiitk sergiitk commented Sep 30, 2022 •
edited

@sergiitk sergiitk marked this pull request as ready for review September 30, 2022 21:19
@sergiitk sergiitk added release notes: no Indicates if PR should not be in release notes area/psm interop labels Sep 30, 2022
gnossen
gnossen approved these changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@gnossen gnossen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please also add a TODO to unpin? This is good signal for us currently when this breaks.

@sergiitk sergiitk enabled auto-merge (squash) September 30, 2022 23:18
@sergiitk sergiitk merged commit 203bc0d into grpc:master Sep 30, 2022
@sergiitk sergiitk deleted the xds-interop-gce-protobuf branch October 1, 2022 00:23
sergiitk added a commit to sergiitk/grpc that referenced this pull request Oct 1, 2022
@sergiitk
xDS interop GCE framework: pin grpcio-tools to use protobuf 3.x (grpc…
cbb2ff2 
…#31191)
sergiitk added a commit to sergiitk/grpc that referenced this pull request Oct 1, 2022
@sergiitk
xDS interop GCE framework: pin grpcio-tools to use protobuf 3.x (grpc…
b260aa0 
…#31191)
sergiitk added a commit to sergiitk/grpc that referenced this pull request Oct 1, 2022
@sergiitk
xDS interop GCE framework: pin grpcio-tools to use protobuf 3.x (grpc…
2901d33 
…#31191)
sergiitk added a commit to sergiitk/grpc that referenced this pull request Oct 1, 2022
@sergiitk
xDS interop GCE framework: pin grpcio-tools to use protobuf 3.x (grpc…
7500bab 
…#31191)
sergiitk added a commit to sergiitk/grpc that referenced this pull request Oct 1, 2022
@sergiitk
xDS interop GCE framework: pin grpcio-tools to use protobuf 3.x (grpc…
8db7315 
…#31191)
sergiitk added a commit to sergiitk/grpc that referenced this pull request Oct 1, 2022
@sergiitk
xDS interop GCE framework: pin grpcio-tools to use protobuf 3.x (grpc…
046ed2b 
…#31191)
This was referenced Oct 1, 2022
Merged
Merged
Merged
Merged
Merged
Merged
sergiitk added a commit that referenced this pull request Oct 3, 2022
@sergiitk
xDS interop GCE framework: pin grpcio-tools to use protobuf 3.x (#31191…
6a0d3e0 
…) (#31196)
sergiitk added a commit that referenced this pull request Oct 3, 2022
@sergiitk
xDS interop GCE framework: pin grpcio-tools to use protobuf 3.x (#31191…
ab687a8 
…) (#31197)
ejona86 pushed a commit that referenced this pull request Oct 3, 2022
@sergiitk
xDS interop GCE framework: pin grpcio-tools to use protobuf 3.x (#31191…
c451df5 
…) (#31198)
ejona86 pushed a commit that referenced this pull request Oct 3, 2022
@sergiitk
xDS interop GCE framework: pin grpcio-tools to use protobuf 3.x (#31191…
80478df 
…) (#31199)
ejona86 pushed a commit that referenced this pull request Oct 3, 2022
@sergiitk
xDS interop GCE framework: pin grpcio-tools to use protobuf 3.x (#31191…
2e9625d 
…) (#31200)
ejona86 pushed a commit that referenced this pull request Oct 3, 2022
@sergiitk
xDS interop GCE framework: pin grpcio-tools to use protobuf 3.x (#31191…
0a1c8d3 
…) (#31201)
@copybara-service copybara-service bot added the imported Specifies if the PR has been imported to the internal repository label Oct 3, 2022
This was referenced Oct 3, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnossen gnossen gnossen approved these changes

Assignees
No one assigned
Labels
area/psm interop bloat/none imported Specifies if the PR has been imported to the internal repository per-call-memory/neutral per-channel-memory/neutral release notes: no Indicates if PR should not be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sergiitk @gnossen