New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build with System OpenSSL on Mac OS arm64 #31096
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Boringssl currently does not support macOS arm64, so installation on these platform with default config will undoubtedly fail, that means the env var 'BUILD_WITH_SYSTEM_OPENSSL' must be set to true.
|
gnossen
approved these changes
Oct 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
gnossen
changed the title
fix: grpcio fails to build from source on Apple Silicon mac #(25082)
Build with System OpenSSL on Mac OS arm64
Oct 18, 2022
gnossen
reviewed
Oct 18, 2022
gnossen
approved these changes
Oct 19, 2022
gnossen
added
area/build
release notes: yes
Indicates if PR needs to be in release notes
kokoro:run
labels
Oct 19, 2022
One minor thing: Can you please run |
Formatted: 200fb50 |
copybara-service
bot
added
the
imported
Specifies if the PR has been imported to the internal repository
label
Oct 20, 2022
gnossen
added a commit
to gnossen/grpc
that referenced
this pull request
Nov 22, 2022
This reverts commit b3d9833.
gnossen
added a commit
to gnossen/grpc
that referenced
this pull request
Nov 22, 2022
This reverts commit b3d9833.
gnossen
added a commit
that referenced
this pull request
Nov 22, 2022
gnossen
added a commit
that referenced
this pull request
Nov 22, 2022
jtattermusch
added a commit
that referenced
this pull request
Jan 11, 2023
* Bump v1.51.x to 1.51.0-pre1 (#31622) * bump version to 1.51.0-pre1 * regenerate projects * Branch 1.51.x: Cherrypick "Adding token url validation cases for psc endpoints #31616" and "Added url validation for aws metadata endpoints in aws external account #31626" (#31646) * Adding token url validation cases for psc endpoints (#31616) * Adding validation case for psc endpoint * formatting fix * Added url validation for aws metadata endpoints in aws external account (#31626) * Added url validation for aws metadata endpoints in aws external account * addressing review comments * fix error message back * Fix broken test * xds resolver: fix edge cases in interactions between LDS and RDS (#31668) (#31672) * xds resolver: fix edge cases in interactions between LDS and RDS * improve SwitchFromInlineRouteConfigToRds test * clang-tidy * Automated change: Fix sanity tests Co-authored-by: markdroth <markdroth@users.noreply.github.com> Co-authored-by: markdroth <markdroth@users.noreply.github.com> * xDS: fix crash on wrong listener type (both client and server side) (#31684) (#31691) * xds resolver: fix crash on wrong listener type * fix same bug on server side * fix clang-tidy and add requested TODO * Bump v1.51.x to v1.51.0 (#31705) * bump version to 1.51.0 * regenerate projects * Revert "Build with System OpenSSL on Mac OS arm64 (#31096)" (#31739) This reverts commit b3d9833. * Bump v1.51.x to 1.51.1 (#31740) * Bump to 1.51.1 * Regenerate projects Co-authored-by: Richard Belleville <rbellevi@google.com> Co-authored-by: aeitzman <12433791+aeitzman@users.noreply.github.com> Co-authored-by: Mark D. Roth <roth@google.com> Co-authored-by: markdroth <markdroth@users.noreply.github.com>
wanlin31
pushed a commit
that referenced
this pull request
May 18, 2023
wanlin31
pushed a commit
that referenced
this pull request
May 18, 2023
* Bump v1.51.x to 1.51.0-pre1 (#31622) * bump version to 1.51.0-pre1 * regenerate projects * Branch 1.51.x: Cherrypick "Adding token url validation cases for psc endpoints #31616" and "Added url validation for aws metadata endpoints in aws external account #31626" (#31646) * Adding token url validation cases for psc endpoints (#31616) * Adding validation case for psc endpoint * formatting fix * Added url validation for aws metadata endpoints in aws external account (#31626) * Added url validation for aws metadata endpoints in aws external account * addressing review comments * fix error message back * Fix broken test * xds resolver: fix edge cases in interactions between LDS and RDS (#31668) (#31672) * xds resolver: fix edge cases in interactions between LDS and RDS * improve SwitchFromInlineRouteConfigToRds test * clang-tidy * Automated change: Fix sanity tests Co-authored-by: markdroth <markdroth@users.noreply.github.com> Co-authored-by: markdroth <markdroth@users.noreply.github.com> * xDS: fix crash on wrong listener type (both client and server side) (#31684) (#31691) * xds resolver: fix crash on wrong listener type * fix same bug on server side * fix clang-tidy and add requested TODO * Bump v1.51.x to v1.51.0 (#31705) * bump version to 1.51.0 * regenerate projects * Revert "Build with System OpenSSL on Mac OS arm64 (#31096)" (#31739) This reverts commit b3d9833. * Bump v1.51.x to 1.51.1 (#31740) * Bump to 1.51.1 * Regenerate projects Co-authored-by: Richard Belleville <rbellevi@google.com> Co-authored-by: aeitzman <12433791+aeitzman@users.noreply.github.com> Co-authored-by: Mark D. Roth <roth@google.com> Co-authored-by: markdroth <markdroth@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/build
imported
Specifies if the PR has been imported to the internal repository
lang/Python
release notes: yes
Indicates if PR needs to be in release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boringssl currently does not support macOS arm64, so installation on these platform with default config will undoubtedly fail. That means the env var 'GRPC_PYTHON_BUILD_SYSTEM_OPENSSL' must be set to true, but
GRPC_PYTHON_BUILD_SYSTEM_ZLIB=1
mentioned in this issue #25082, I think it ain't necessary, because:GRPC_PYTHON_BUILD_SYSTEM_ZLIB=1
I don't know when will grpc provide python wheel for macOS arm64, but at least I think installing grpcio from source by default should be not failed.
@gnossen