Re-add compiler protos to grpcio-tools #31062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnossen
added
lang/Python
release notes: no
grpc-checks
bot
added
bloat/none
per-call-memory/neutral
per-channel-memory/neutral
labels
XuanWang-Amos
approved these changes
Sep 20, 2022
gnossen
added a commit
to gnossen/grpc
that referenced
this pull request
Sep 21, 2022
* Re-add compiler protos to grpcio-tools * Attempt to break * Actually fail if protobufs don't compile. Who wrote this thing? * Add an actual test * yapf * Whoops. Thought I'd reverted you * Please the formatter gods
gnossen
added a commit
that referenced
this pull request
Sep 21, 2022
copybara-service
bot
added
the
imported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31020
We previously relied on
@com_google_protobuf//:well_known_protosto provide the list of protos that should be bundled intogrpcio-tools. However, the protobuf repo recently split this target into two:@com_google_protobuf//:well_known_type_protosand@com_google_protobuf//:built_in_runtime_protos.When #30377 consumed the protobuf repo's breaking change, it pulled in
:well_known_type_protosbut not:built_in_runtime_protos. This PR corrects that and adds a test for all protos that should be bundled withgrpcio-tools.