Remove grpc_codegen
#30960
Merged
Remove grpc_codegen
#30960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralphchung
added
release notes: no
grpc-checks
bot
added
bloat/none
per-call-memory/neutral
per-channel-memory/neutral
labels
Vignesh2208
approved these changes
Sep 16, 2022
ctiller
reviewed
Sep 20, 2022
| @@ -2169,7 +2167,7 @@ grpc_cc_library( | |||
| deps = [ | |||
| "gpr", | |||
| "gpr_spinlock", | |||
| "grpc_codegen", | |||
| "grpc_public_hdrs", | |||
There was a problem hiding this comment.
It seems like here and in other places we want some concrete target, not the headers only target - or am I missing something?
Please check that we're only consuming interface not implementation, and either fix the dependency or include a note in the review for why this is safe here and in all places we're using this target.
There was a problem hiding this comment.
Have checked with original build target https://github.com/grpc/grpc/blob/master/BUILD#L4263-L4278. It has only public headers, which best corresponds to the grpc_public_hdrs.
Previous try was using grpc_base. However, cherry picking fails due to linkage error. This is mysterious and I have no idea so far.
ctiller
approved these changes
Sep 21, 2022
copybara-service
bot
added
the
imported
ralphchung
added a commit
that referenced
this pull request
Sep 22, 2022
This reverts commit b2d64ef.
ralphchung
added a commit
that referenced
this pull request
Sep 22, 2022
This reverts commit eada386.
ralphchung
added a commit
that referenced
this pull request
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR requires cherry picking before merging.
In #30570, build target
grpc_codegenhas been merged togrpc_base. We no longer need this.