Backport to 1.48: subchannel list: fix ubsan error #30412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* don't expose vector type * don't down-cast from inside base class ctor
markdroth
added
the
release notes: no
veblush
approved these changes
Jul 26, 2022
apolcyn
added a commit
that referenced
this pull request
Aug 16, 2022
* Bump version to 1.48.0-pre1 (on v1.48.x branch) (#30194) * bump version to 1.48.0-pre1 * regenerate projects * Bump version to 1.48.0 (on v1.48.x branch) (#30326) * bump version to 1.48.0 * regenerate projects * xds interop: choose correct cluster in grpc_xds_k8s_lb_python.sh (1.48.x backport) (#30329) * subchannel list: fix ubsan error (#30393) (#30412) * don't expose vector type * don't down-cast from inside base class ctor * xDS interop: add missing image tagging to the buildscripts (#30520) (#30529) Co-authored-by: Yash Tibrewal <yashkt@google.com> Co-authored-by: Sergii Tkachenko <sergiitk@google.com> Co-authored-by: Mark D. Roth <roth@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #30393 to 1.48.