Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove (experimental) PUT support #28792

Closed
ejona86 opened this issue Feb 4, 2022 · 3 comments · Fixed by #28922
Closed

Remove (experimental) PUT support #28792

ejona86 opened this issue Feb 4, 2022 · 3 comments · Fixed by #28922

Comments

@ejona86
Copy link
Member

ejona86 commented Feb 4, 2022

At least one user used PUT without realizing it is an incomplete experiment, much more so than other experimental APIs. grpc/grpc-go#2881 (comment) (and b/217892555). That caused compatibility issues when Go improved its implementation to verify the HTTP method is POST.

I believe I heard @yashykt recently removed the GET support in C (but I failed to find the PR quickly; "get" is hard to search for). Yes, PUT probably has very low maintenance burden, but grpc dev interest in PUT is lower than that of GET, so at this point it seems best to remove the API. If we don't want to do that, I guess we can put a "DO NOT USE" message in the docs.

CC @markdroth, @bdhess, @dfawley

@yashykt
Copy link
Member

yashykt commented Feb 18, 2022

The last I looked at it, we decided not to remove GET/PUT support, but @ctiller just put out #28922

@ejona86
Copy link
Member Author

ejona86 commented Feb 18, 2022

@yashykt, if GET is still present, how was the HTTP method handled for RBAC?

@yashykt
Copy link
Member

yashykt commented Apr 5, 2022

@yashykt, if GET is still present, how was the HTTP method handled for RBAC?

It was handled similar to other metadata types. (The method metadata was already available to the rbac filter implementation)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants