Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable authorization_policy_provider_test on iOS #27927

Merged
merged 1 commit into from
Nov 3, 2021
Merged

disable authorization_policy_provider_test on iOS #27927

merged 1 commit into from
Nov 3, 2021

Conversation

markdroth
Copy link
Member

This test is failing on iOS and shouldn't be needed there anyway, since we don't support servers on iOS.

@markdroth markdroth added the release notes: no Indicates if PR should not be in release notes label Nov 3, 2021
dennycd
dennycd approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@dennycd dennycd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks !

@dennycd
Copy link
Contributor

dennycd commented Nov 3, 2021

grpc/grpc-ios#43

ashithasantosh
ashithasantosh approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@ashithasantosh ashithasantosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you

@markdroth
Copy link
Member Author

Test failures are both infrastructure issues.

@markdroth markdroth merged commit e251ee9 into grpc:master Nov 3, 2021
@markdroth markdroth deleted the disable_authz_tests_on_ios branch November 3, 2021 18:55
@copybara-service copybara-service bot added the imported Specifies if the PR has been imported to the internal repository label Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dennycd dennycd dennycd approved these changes

@ashithasantosh ashithasantosh ashithasantosh approved these changes

Assignees
No one assigned
Labels
imported Specifies if the PR has been imported to the internal repository lang/c++ release notes: no Indicates if PR should not be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@markdroth @dennycd @ashithasantosh