Expose grpc++_binder through grpc++ #27891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sifmelcara
added
the
release notes: no
napathome
approved these changes
Nov 2, 2021
A config is added so we can disable it if needed
sifmelcara
force-pushed
the
add-binder-to-grpcpp-bazel-2021-11-01
branch
from
3e133e1
to
f3e72c1
Compare
|
Rebase and resolved merge conflict. Now this exposes through Will double check copybara import and size impact. Will merge if they look fine |
|
Retrigger CI. xds test failed for some reason |
Not everyone who build shared library is using bazel so we need to provide this option to disable binder transport code.
sifmelcara
force-pushed
the
add-binder-to-grpcpp-bazel-2021-11-01
branch
from
6d66959
to
7c8bb7b
Compare
|
Add a new commit that allows users to disable binder transport by defining |
|
Can confirm that the shared library does not have any size increase after |
copybara-service
bot
added
the
imported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the meeting, this is probably a better way to expose the code.
This should not affect binary size as long as user does not include binder headers and they are static linking.
A config option is provided so user can pass
--define=grpc_no_binder=trueto bazel to disable the dependency.A copybara import was created to dry run this change, and it looks fine