[Backport] Fix visibility of libprotobuf symbols in protoc_compiler.so on Mac #25010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix visibility of libprotobuf symbols in protoc_compiler.so on Mac
gnossen
added
kind/bug
lang/Python
area/build
release notes: yes
yulin-liang
approved these changes
Dec 16, 2020
|
Thanks Richard, Jan also has a backport(#24995), please let me know when all of your backports are merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #24992. Fixes #24897.
@yulin-liang After this, I just need one more backport before we can go for a patch.