Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop building protoc x86 artifacts on macos #24870

Merged
merged 3 commits into from Dec 3, 2020
Merged

Stop building protoc x86 artifacts on macos #24870

merged 3 commits into from Dec 3, 2020

Conversation

jtattermusch
Copy link
Contributor

@jtattermusch jtattermusch commented Dec 1, 2020 •
edited

Prerequisite for #24860.

MacOS mojave no longer has a toolchain to build 32bit binaries.

@jtattermusch
Copy link
Contributor Author

CC @veblush

@jtattermusch jtattermusch added release notes: yes Indicates if PR needs to be in release notes lang/all wrapped languages labels Dec 1, 2020
@jtattermusch
Copy link
Contributor Author

Adhoc distribtests: https://g3c.corp.google.com/results/invocations/3a971431-707f-4f02-9547-69e7c3e47de9/targets

@jtattermusch
Copy link
Contributor Author

Looks like ruby package build also tries to include protoc x86 macos artifacts:

https://g3c.corp.google.com/results/invocations/c96768fb-4cf6-4635-8438-e71eae75c019/targets/github%2Fgrpc;config=default/tests

@jtattermusch
Copy link
Contributor Author

jtattermusch commented Dec 2, 2020 •
edited

Another adhoc distribtest run: https://g3c.corp.google.com/results/invocations/3125c1bd-2ce8-43db-883f-39fb5000a4e5/targets

@jtattermusch jtattermusch marked this pull request as ready for review December 2, 2020 14:38
@jtattermusch jtattermusch mentioned this pull request Dec 2, 2020
Merged
@jtattermusch
Copy link
Contributor Author

Yet another adhoc distribtest
https://g3c.corp.google.com/results/invocations/d17a3a74-d0bf-43fe-b25a-88a250574e4c/targets

@jtattermusch
Copy link
Contributor Author

Yet another adhoc distribtest
https://g3c.corp.google.com/results/invocations/d17a3a74-d0bf-43fe-b25a-88a250574e4c/targets

Ruby grpc-tools gem package build is now passing.

@jtattermusch
Copy link
Contributor Author

Ruby failure is a test flake
https://source.cloud.google.com/results/invocations/736f772a-c8d1-4e82-8278-7dca8f618345/targets/github%2Fgrpc%2Frun_tests%2Fruby_linux_dbg_native%2Ftools%2Frun_tests%2Fhelper_scripts%2Frun_ruby.sh/tests

@jtattermusch jtattermusch merged commit 010d9f3 into grpc:master Dec 3, 2020
yulin-liang added a commit to yulin-liang/grpc that referenced this pull request Jan 12, 2021
@yulin-liang
backport of grpc#24870
1633fdd
yulin-liang added a commit to yulin-liang/grpc that referenced this pull request Jan 12, 2021
@yulin-liang
backport of grpc#24870
0ec57a9
drfloob added a commit to drfloob/grpc that referenced this pull request Jan 20, 2021
@drfloob
Fix broken nightly build and publish due to MacOS x86 protoc deprecation
289eaab 
The grpc_publish_packages.sh build has been broken since 2020-12-03 due
to commit 010d9f3, after which protoc artifacts for MacOS x86 were no
longer being built. See grpc#24870. The internal errors for
`grpc/core/nightly/grpc_publish_packages` are failing on `chmod +x
<nothing>`.

As pointed out in grpc#25210, https://packages.grpc.io/ has not been updated
since 2020-12-02.
@drfloob drfloob mentioned this pull request Jan 20, 2021
Merged
@alto-ruby alto-ruby mentioned this pull request Jul 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veblush veblush veblush approved these changes

Assignees

@veblush veblush

Labels
lang/all wrapped languages release notes: yes Indicates if PR needs to be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jtattermusch @veblush