Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby grpc gem indirectly drops support for ruby version < 2.5 #22990

Closed
estolfo opened this issue May 19, 2020 · 2 comments
Closed

Ruby grpc gem indirectly drops support for ruby version < 2.5 #22990

estolfo opened this issue May 19, 2020 · 2 comments

Comments

@estolfo
Copy link

estolfo commented May 19, 2020

Hi, thanks for this Ruby gem!

I noticed that a new version (3.12.0) of the google-protobuf gem now only supports ruby >= 2.5. The previous version, 3.11, supports ruby >= 2.3.

The grpc gem's dependency on google-protobuf is defined as '~> 3.11'. That means that now the latest version of google-protobuf will be installed with the grpc gem and won't support ruby 2.3 or 2.4 though the required ruby version is defined as >= 2.3.0.

I leave it up to you to decide what you'd like to do :) Whether you want to update your defined required ruby version and the google-protobuf dependency to ~> 3.12 or if you want to restrict the version of google-protobuf installed based on the ruby version.
Or if you want to leave it up to the user to explicitly install google-protobuf version 3.11 when using ruby < 2.5.
Thanks!

@stanley-cheung
Copy link
Contributor

Related to #22978

@alto-ruby
Copy link
Contributor

dropped ruby 2.5 support in #30699

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants