Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dotnet SDK 3 for C# build #22964

Merged
merged 5 commits into from
Jun 9, 2021

Conversation

jtattermusch
Copy link
Contributor

@jtattermusch jtattermusch commented May 15, 2020

No description provided.

@jtattermusch
Copy link
Contributor Author

Now getting this error for some of the tests:

It was not possible to find any compatible framework version
The framework 'Microsoft.NETCore.App', version '2.1.0' was not found.
  - The following frameworks were found:
      3.1.4 at [/usr/share/dotnet/shared/Microsoft.NETCore.App]

You can resolve the problem by installing the specified framework and/or SDK.

@stale
Copy link

stale bot commented Dec 8, 2020

This issue/PR has been automatically marked as stale because it has not had any update (including commits, comments, labels, milestones, etc) for 30 days. It will be closed automatically if no further update occurs in 7 day. Thank you for your contributions!

@jtattermusch jtattermusch changed the title DRAFT: upgrade dotnet SDK 3 for C# build Upgrade dotnet SDK 3 for C# build Jun 8, 2021
@jtattermusch jtattermusch marked this pull request as ready for review June 8, 2021 12:36
@jtattermusch jtattermusch added the release notes: no Indicates if PR should not be in release notes label Jun 8, 2021
@jtattermusch jtattermusch merged commit a44bafe into grpc:master Jun 9, 2021
jtattermusch added a commit that referenced this pull request Jun 9, 2021
* upgrade dotnet SDK 3 for C# build

* add C# global.json

* install dotnet SDK 3 on macos

* upgrade C# docker images to debian buster

* regenerate dockerfiles
paulosjca added a commit to paulosjca/grpc that referenced this pull request Jun 10, 2021
This is a workaround for a breakage introduced by grpc#22964.
paulosjca added a commit that referenced this pull request Jun 10, 2021
This is a workaround for a breakage introduced by #22964.
@veblush
Copy link
Contributor

veblush commented Jun 10, 2021

This started breaking build & distribtest. linux, windows, mac

veblush added a commit that referenced this pull request Jun 10, 2021
veblush added a commit that referenced this pull request Jun 10, 2021
jtattermusch added a commit to jtattermusch/grpc that referenced this pull request Jun 11, 2021
@jtattermusch
Copy link
Contributor Author

Ooops, sorry.

jtattermusch added a commit that referenced this pull request Jun 15, 2021
* Revert "Revert "Upgrade dotnet SDK 3 for C# build (#22964)" (#26462)"

This reverts commit 736d914.

* Revert "Exclude csharp from performance test continuous runs. (#26458)"

This reverts commit 6744e8f.

* switch remaining tests to C# buster image

* remove C#'s global.json (which requires dotnet SDK 3+)

* dotnet SDK3 currently breaks C# package build

* regenerate dockerfiles
apolcyn added a commit that referenced this pull request Jun 17, 2021
* Bump version to v1.38.0-pre1 (#26208)

* Bump version to v1.38.0-pre1

* Regenerate projects

* [Backport][v1.38.x] Add EventEngine's port.h to the podspec (#26222)

Backport of #26220 to v1.38.x. This is the only backport, since the EventEngine code was introduced after v1.37 was cut.

This file is needed for the Objective-C cocoapod build.

* fix xds resolver to add XdsClient to channel args even on errors (#26282) (#26288)

Co-authored-by: Mark D. Roth <roth@google.com>

* Backport config update timeout change to v1.38.x (#26276)

* Enable Traffic Director time tracer (#26111)

* Just update the timeout (#26223)

* Increase xds job timeouts (#26187)

* Revert grpc_xds_k8s job timeouts back to 120 mins (#26219)

* Revert grpc_xds_k8s_python timeout to 120mins (#26221)

Seems to have been inadvertently increased in #26187

Co-authored-by: Eric Gribkoff <ericgribkoff@google.com>
Co-authored-by: Yash Tibrewal <yashkt@google.com>

* Bump v1.38.x to v1.38.0  (#26317)

* Bump version to v1.38.0

* Regenerate projects

* Provide custom sponge configs to exclude manual runs from testgrid (#26283) (#26313)

* Provide custom sponge configs

* Correct the script

* Allow test scripts to produce artifacts through Docker

* Overcome the direcotry clone in our docker script

* Expose TESTGRID_EXCLUDE and GIT_ORIGIN_URL through docker run

* Make sanity tests happy

* Revert "Provide custom sponge configs to exclude manual runs from testgrid (#26283) (#26313)" (#26324)

This reverts commit 54dc182.

* better way of building protoc aarch64 artifacts (#26423)

* Backport #26430 and #26435 to v1.38.x (#26436)

* workaround #26279 at the expense of binary compatibility

* correctly tag aarch64 wheels as manylinux_2_24

* remove unnecessary comments left by #26430

* Backport #22964 into v1.38.x (#26448)

* upgrade dotnet SDK 3 for C# build

* add C# global.json

* install dotnet SDK 3 on macos

* upgrade C# docker images to debian buster

* regenerate dockerfiles

* Backport fixes from #26465 to v1.38.x (#26466)

* switch remaining tests to C# buster image

* remove C#'s global.json (which requires dotnet SDK 3+)

* dotnet SDK3 currently breaks C# package build

* regenerate dockerfiles

Co-authored-by: Yash Tibrewal <yashkt@google.com>
Co-authored-by: AJ Heller <hork@google.com>
Co-authored-by: donnadionne <donnadionne@google.com>
Co-authored-by: Mark D. Roth <roth@google.com>
Co-authored-by: Lidi Zheng <lidiz@google.com>
Co-authored-by: Eric Gribkoff <ericgribkoff@google.com>
Co-authored-by: Jan Tattermusch <jtattermusch@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
disposition/never stale release notes: no Indicates if PR should not be in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants