Expose getName() in MethodDescriptor and fix TS definitions. #1289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampajano
changed the title
sampajano
force-pushed
the
1.expose.methoddescriptor.getname
branch
from
2cd8610
to
c1bb5dd
Compare
sampajano
force-pushed
the
1.expose.methoddescriptor.getname
branch
from
c1bb5dd
to
451b97b
Compare
stanley-cheung
approved these changes
Sep 30, 2022
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backgrounds:
getName()still seemed useful to some users per discussion in MethodDescriptor<REQ, RESP>.getName() is not a function #1285Hence we're re-exposing only the getName() method on MethodDescriptor, hoping it won't cause a code size issue internally and also address some user needs.