Improve server-related types exported by grpc-js #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
reviewed
Jul 17, 2019
packages/grpc-js/src/server-call.ts
Outdated
| @@ -18,13 +18,14 @@ | |||
| import { EventEmitter } from 'events'; | |||
| import * as http2 from 'http2'; | |||
| import { Duplex, Readable, Writable } from 'stream'; | |||
| import * as util from 'util'; | |||
There was a problem hiding this comment.
util.isNumber() and util.isString() are deprecated in favor of typeof value === 'number' and typeof value === 'string', respectively.
packages/grpc-js/src/server-call.ts
Outdated
| ? error.metadata | ||
| : new Metadata(), | ||
| }; | ||
|
|
||
| if (error.hasOwnProperty('code') && Number.isInteger(error.code)) { | ||
| if ('code' in error && util.isNumber(error.code) && Number.isInteger(error.code)) { |
There was a problem hiding this comment.
The util.isNumber() (or typeof error.code === 'number') check shouldn't be necessary due to the Number.isInteger() call.
There was a problem hiding this comment.
I think Typescript was not happy with calling Number.isInteger on that value without verifying that it was a number.
There was a problem hiding this comment.
I think you're right: microsoft/TypeScript#21199 😕
nicolasnoble
approved these changes
Jul 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mainly makes the server call types and
Server#registerServicefunction signature more specific, the server error types more permissive, and exports some more types needed for writing service implementations.Also, this fixes a typo in the native library's
index.d.tsthat got brought up in #965. That class is essentially internal, so code written using the typo works. I have added an alias to avoid breaking that.