Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protobufjs security issue #360

Closed
jschirrmacher opened this issue May 22, 2018 · 1 comment
Closed

protobufjs security issue #360

jschirrmacher opened this issue May 22, 2018 · 1 comment

Comments

@jschirrmacher
Copy link

Problem description

npm audit reports a possible vulnerability to a denial of service attack.
See https://nodesecurity.io/advisories/605

Is there any objection to require at least protobufjs 6.8.6?

@nicolasnoble
Copy link
Member

nicolasnoble commented May 22, 2018

First, which package exactly are you talking about exactly ?

Also, yes, requiring protobufjs 6.8.6 would be an API breaking change for the grpc package. And https://nodesecurity.io/advisories/605 is outdated, and isn't showing the fact that 5.0.3 is fixed also.

Closing because duplicate of #277.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants