grpc-js-xds: Fix bug that prevented priority name reuse #2356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Outlier detection in xDS is broken without this change. Specifically, the
newLocalityPrioritiesmap tracks which priority each locality is currently in, so that priorities that contain the same locality can use the same name the next time an update is sent. Without this added line, that map will not be populated at all, so priority names will never be reused. This causes the priority policy to always create new LB policy instances for its children, which resets the persistent data the outlier detection LB policy uses to make ejection determinations.I also updated the tracer list in the interop Dockerfile to include some more recently-added tracers.