grpc-tools: Force GNU format for artifact tarballs #2288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murgatroid99
force-pushed
the
grpc-tools_mac_tarball_fix
branch
from
93d5528
to
2ddd628
Compare
|
This seems to fix the problem, based on manual testing. |
gnossen
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2287. The current release has a bug where the Mac artifacts are extracted into a directory called
GNUSparseFiles.0. This comes from extracting a sparse file from a POSIX/PAX format archive (documentation).fileshows that only the Mac artifacts are in the POSIX format, and the others are in the GNU format. I am assuming that thetarimplementation in the Mac build environment defaults to the POSIX format, which would mean that we can avoid this problem by forcing the GNU format.